threshold issueshttps://gitlab.pavlovia.org/sagarrpandav/threshold/-/issues2021-10-01T07:19:20Zhttps://gitlab.pavlovia.org/sagarrpandav/threshold/-/issues/23Discussion: Level of parameters2021-10-01T07:19:20ZSagar R PandavDiscussion: Level of parameters*Created by: peilingjiang*
As mentioned in EasyEyes/control-panel#1, there are two levels of parameters: **experiment** (e.g., if use RC), **block** (e.g., if display fixation). Experiment-level params should be parsed at the beginning of the experiment and block-level params should be parsed at the beginning of each block (now within every trial). Should we add an extra column in the input sheet to identify the level of params?*Created by: peilingjiang*
As mentioned in EasyEyes/control-panel#1, there are two levels of parameters: **experiment** (e.g., if use RC), **block** (e.g., if display fixation). Experiment-level params should be parsed at the beginning of the experiment and block-level params should be parsed at the beginning of each block (now within every trial). Should we add an extra column in the input sheet to identify the level of params?https://gitlab.pavlovia.org/sagarrpandav/threshold/-/issues/18[FEATURE] Redesign the (PsychoJS) hello and goodbye screens2021-10-01T07:19:20ZSagar R Pandav[FEATURE] Redesign the (PsychoJS) hello and goodbye screens*Created by: denispelli*
**Is your feature request related to a problem? Please describe.**
**What's easily changed?**
Show our logo!
Please clean up the request for participant name. It should say "Welcome to EasyEyes Threshold."
<!-- A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] -->
The Hello and Goodbye screens are ugly.
**Describe the solution you'd like**
**When I aborted by hitting Escape it says "Thank you for your patience."
Please change "patience" to "participation."**
<!-- A clear and concise description of what you want to happen. -->
**Additional context**
<!-- Add any other context or screenshots about the feature request here. -->
*Created by: denispelli*
**Is your feature request related to a problem? Please describe.**
**What's easily changed?**
Show our logo!
Please clean up the request for participant name. It should say "Welcome to EasyEyes Threshold."
<!-- A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] -->
The Hello and Goodbye screens are ugly.
**Describe the solution you'd like**
**When I aborted by hitting Escape it says "Thank you for your patience."
Please change "patience" to "participation."**
<!-- A clear and concise description of what you want to happen. -->
**Additional context**
<!-- Add any other context or screenshots about the feature request here. -->
https://gitlab.pavlovia.org/sagarrpandav/threshold/-/issues/16[FEATURE] Blanking and clipping of marks to prevent spurious masking & crowding.2021-10-01T07:19:20ZSagar R Pandav[FEATURE] Blanking and clipping of marks to prevent spurious masking & crowding.*Created by: denispelli*
This is explained in the EasyEyes Threshold manual (Inputs sheet), under marking...*Created by: denispelli*
This is explained in the EasyEyes Threshold manual (Inputs sheet), under marking...https://gitlab.pavlovia.org/sagarrpandav/threshold/-/issues/14[FEATURE] Implement handling of the escape key.2021-10-01T07:19:20ZSagar R Pandav[FEATURE] Implement handling of the escape key.*Created by: denispelli*
This is spelled out in the EasyEyes Threshold manual. See
keyEscapeEnable
in the Input sheet.
Assigned to Sagar.
*Created by: denispelli*
This is spelled out in the EasyEyes Threshold manual. See
keyEscapeEnable
in the Input sheet.
Assigned to Sagar.
https://gitlab.pavlovia.org/sagarrpandav/threshold/-/issues/13[FEATURE] Preprocessor should check validity of parameters2021-10-01T07:19:20ZSagar R Pandav[FEATURE] Preprocessor should check validity of parameters*Created by: denispelli*
This is all spelled out in the EasyEyes Threshold manual.
The preprocessor should check validity of:
parameter names
parameters types
Any request fonts should be checked against the list of fonts in the scientist's Font folder in Pavlovia, and the short list of commonly available fonts (like Arial and Verdana).
Also, a current limitation of PsychoJS is that all conditions in a block must have the same number of trials. The preprocessor should enforce this.*Created by: denispelli*
This is all spelled out in the EasyEyes Threshold manual.
The preprocessor should check validity of:
parameter names
parameters types
Any request fonts should be checked against the list of fonts in the scientist's Font folder in Pavlovia, and the short list of commonly available fonts (like Arial and Verdana).
Also, a current limitation of PsychoJS is that all conditions in a block must have the same number of trials. The preprocessor should enforce this.https://gitlab.pavlovia.org/sagarrpandav/threshold/-/issues/12Get data from Pavlovia2021-10-01T07:19:20ZSagar R PandavGet data from Pavlovia*Created by: denispelli*
[FEATURE] We need instructions in the EasyEyes Threshold manual for how to retrieve data from Pavlovia once the experiment is done. It may be enough to just copy what is written in the PsychoPy/JS manual.*Created by: denispelli*
[FEATURE] We need instructions in the EasyEyes Threshold manual for how to retrieve data from Pavlovia once the experiment is done. It may be enough to just copy what is written in the PsychoPy/JS manual.https://gitlab.pavlovia.org/sagarrpandav/threshold/-/issues/11[FEATURE] Add consent screen2021-10-01T07:19:20ZSagar R Pandav[FEATURE] Add consent screen*Created by: peilingjiang*
**Is your feature request related to a problem? Please describe.**
<!-- A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] -->
**Describe the solution you'd like**
https://docs.google.com/spreadsheets/d/1x65NjykMm-XUOz98Eu_oo6ON2xspm_h0Q0M2u6UGtug/edit#gid=1385703808
See EasyEyes Manual Web sheet for explanation fo how the consent form and fonts should be handled. We need to allow the scientist to upload any number of consent forms and fonts to the ConsentForms and Fonts folders in an EasyEyesResources folder in the scientist's Pavlovia account. The file names will later be specified as values of the _consentForm and targetFont parameters.
<!-- A clear and concise description of what you want to happen. -->
Use the value of _consentForm to select a file from EasyEyesResources/ConsentForms/ in the scientist's Pavlovia account. The preprocessor will check that there is a match before uploading threshold.js to Pavlovia. I'm not sure what file formats we should support for the consent document. Markdown is good for reflowing the lines to adapt to various screens sizes. PDF is good for showing a stamped document. Probably Markdown is the more robust solution. Threshold.js will need to flow the text so it's easy to read even on a small screen. The validity of our consent "signatures" could be challenged unless it's easy to read the consent form.
**Additional context**
<!-- Add any other context or screenshots about the feature request here. -->
*Created by: peilingjiang*
**Is your feature request related to a problem? Please describe.**
<!-- A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] -->
**Describe the solution you'd like**
https://docs.google.com/spreadsheets/d/1x65NjykMm-XUOz98Eu_oo6ON2xspm_h0Q0M2u6UGtug/edit#gid=1385703808
See EasyEyes Manual Web sheet for explanation fo how the consent form and fonts should be handled. We need to allow the scientist to upload any number of consent forms and fonts to the ConsentForms and Fonts folders in an EasyEyesResources folder in the scientist's Pavlovia account. The file names will later be specified as values of the _consentForm and targetFont parameters.
<!-- A clear and concise description of what you want to happen. -->
Use the value of _consentForm to select a file from EasyEyesResources/ConsentForms/ in the scientist's Pavlovia account. The preprocessor will check that there is a match before uploading threshold.js to Pavlovia. I'm not sure what file formats we should support for the consent document. Markdown is good for reflowing the lines to adapt to various screens sizes. PDF is good for showing a stamped document. Probably Markdown is the more robust solution. Threshold.js will need to flow the text so it's easy to read even on a small screen. The validity of our consent "signatures" could be challenged unless it's easy to read the consent form.
**Additional context**
<!-- Add any other context or screenshots about the feature request here. -->
Shikhar VaishShikhar Vaishhttps://gitlab.pavlovia.org/sagarrpandav/threshold/-/issues/6[FEATURE] Plan how EasyEyes web page will control Pavlovia2021-10-01T07:19:20ZSagar R Pandav[FEATURE] Plan how EasyEyes web page will control Pavlovia*Created by: peilingjiang*
**Is your feature request related to a problem? Please describe.**
<!-- A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] -->
**Describe the solution you'd like**
<!-- A clear and concise description of what you want to happen. -->
**Additional context**
<!-- Add any other context or screenshots about the feature request here. -->
*Created by: peilingjiang*
**Is your feature request related to a problem? Please describe.**
<!-- A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] -->
**Describe the solution you'd like**
<!-- A clear and concise description of what you want to happen. -->
**Additional context**
<!-- Add any other context or screenshots about the feature request here. -->
Shikhar VaishShikhar Vaishhttps://gitlab.pavlovia.org/sagarrpandav/threshold/-/issues/5[FEATURE] Add instructions for participants from CriticalSpacing2021-10-01T07:19:20ZSagar R Pandav[FEATURE] Add instructions for participants from CriticalSpacing*Created by: peilingjiang*
**Is your feature request related to a problem? Please describe.**
<!-- A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] -->
**Describe the solution you'd like**
<!-- A clear and concise description of what you want to happen. -->
**Additional context**
<!-- Add any other context or screenshots about the feature request here. -->
*Created by: peilingjiang*
**Is your feature request related to a problem? Please describe.**
<!-- A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] -->
**Describe the solution you'd like**
<!-- A clear and concise description of what you want to happen. -->
**Additional context**
<!-- Add any other context or screenshots about the feature request here. -->
https://gitlab.pavlovia.org/sagarrpandav/threshold/-/issues/4[FEATURE] Get Keypad to work with Threshold2021-10-01T07:19:20ZSagar R Pandav[FEATURE] Get Keypad to work with Threshold*Created by: peilingjiang*
**Is your feature request related to a problem? Please describe.**
<!-- A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] -->
**Describe the solution you'd like**
As documented in the Threshold Manual Inputs sheet,
https://docs.google.com/spreadsheets/d/1x65NjykMm-XUOz98Eu_oo6ON2xspm_h0Q0M2u6UGtug/edit#gid=2021552264
**inclusion of the Keypad should be controlled by the parameter
easyEyesSimulateKeypadBool**
<!-- A clear and concise description of what you want to happen. -->
**Additional context**
<!-- Add any other context or screenshots about the feature request here. -->
*Created by: peilingjiang*
**Is your feature request related to a problem? Please describe.**
<!-- A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] -->
**Describe the solution you'd like**
As documented in the Threshold Manual Inputs sheet,
https://docs.google.com/spreadsheets/d/1x65NjykMm-XUOz98Eu_oo6ON2xspm_h0Q0M2u6UGtug/edit#gid=2021552264
**inclusion of the Keypad should be controlled by the parameter
easyEyesSimulateKeypadBool**
<!-- A clear and concise description of what you want to happen. -->
**Additional context**
<!-- Add any other context or screenshots about the feature request here. -->
Augustin BurchellAugustin Burchell